Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing minio service name #2263

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Missing minio service name #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/cert-manager.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ minio.<namespace>
minio.<namespace>.svc
minio.<namespace>.svc.<cluster domain>
*.<tenant-name>-hl.<namespace>.svc.<cluster domain>
*.<namespace>.svc.<cluster domain>
*.minio.<namespace>.svc.<cluster domain>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjuarezd @allanrogerr It's a good idea to remove *.<namespace>.svc.<cluster domain> from the certificate. But why add *.minio.<namespace>.svc.<cluster domain>? The minio service is not a headless service, so it will always be addressed using minio.<namespace>.svc.<cluster domain> (already in the certificate). Only headless services need a wildcard domain...

PS: I think *.<tenant-name>.minio.<namespace>.svc.<cluster domain> on line 311 is obsolete too. You can't have services that have this amount of dots before the <namespace>.svc.<cluster domain>...

*.<tenant-name>.minio.<namespace>.svc.<cluster domain>'
```

Expand Down
Loading