fix: do not create resources for marked deleted tenant #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
requested review from
pjuarezd,
harshavardhana,
shtripat and
dvaldivia
shtripat
previously approved these changes
Sep 4, 2024
You can deploy tenant with finalizer. And then delete it @shtripat |
pjuarezd
requested changes
Sep 5, 2024
fix: will not create anything for marked deleted tenant
Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
pjuarezd
force-pushed
the
fix_tenant_mark_deletetion
branch
from
9103108
to
1685eac
Compare
pjuarezd
approved these changes
Sep 11, 2024
harshavardhana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: will not create anything for marked deleted tenant