Remove MINIO_OPERATOR_DEPLOYMENT_NAME variable #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
requested review from
harshavardhana,
pjuarezd,
ravindk89,
allanrogerr and
dvaldivia
ramondeklein
force-pushed
the
remove-MINIO_OPERATOR_DEPLOYMENT_NAME
branch
from
aeb7a6c to
95f007b
Compare
harshavardhana
previously approved these changes
Sep 19, 2024
dvaldivia
approved these changes
Sep 19, 2024
ravindk89
approved these changes
Sep 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2242 removed some obsolete code, because the Helm chart always installs the operator with the name
minio-operator. This PR will remove the support for theMINIO_OPERATOR_DEPLOYMENT_NAMEthat could be set to then name of the operator deployment. Because Helm always sets it tominio-operator, there is no real need to keep supporting this.Although it's technically possible to install the operator without the Helm script and use a different name, it's not very likely that this is being used. There are also no checks if other names would actually work correctly. Removing the environment variable seems to be the most logical thing to do.