fix: adding an environment value to enable the ignoring of the name, accessKey and secretKey in configSecret. #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessKey and secretKey in configSecret. In version 6.0.4 the inclusion of [this check](https://github.com/minio/operator/pull/2299/files#diff-1320c71ce4251e5e50c3b17c8aee11659e44a7208d1ab8d5c4f68694c02d9e80R20-R25) broke the ability to pass an existing secret because the default values provided in the values.yaml file, caused the error to trigger. Now we can presume in dev that the vluaes will be provided in line and in prod, they are provided via an existing secret. meh
drew-viles
force-pushed
the
fix-existing-secret
branch
from
b261e45 to
a787a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version
6.0.4the inclusion of this check broke the ability to pass the existingSecret value because the default values provided in the values.yaml file caused the error to trigger. It seems silly to have to provide the following to make it work:Now we can presume in
devthat the values will be provided in line as per the values file and inprod, they are provided via an existing secret.There may be a better way than this, but I've rolled this out and it's fixed the problem I had when upgrading to
6.0.4.