Plugin command cleanup #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested review from
harshavardhana,
ravindk89 and
Praveenrajmani
and removed request for
harshavardhana
ravindk89
reviewed
Sep 17, 2020
harshavardhana
previously approved these changes
Sep 17, 2020
Did you talk to @abperiasamy about this? |
Yes these are his recommendations |
nitisht
changed the title
harshavardhana
force-pushed
the
master
branch
from
9d0a9df to
e707723
Compare
ravindk89
reviewed
Sep 23, 2020
Add tenant generate, tenant expand, and delete Generate command allows production users an opportunity to optionally add/edit any additional fields in the yaml before the tenant actually gets created. Also rename operator create command to operator init, volume add and volume list to expand and info.
ravindk89
approved these changes
Oct 5, 2020
harshavardhana
approved these changes
Oct 7, 2020
jmontleon
pushed a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
Signed-off-by: David Zager <dzager@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tenant generate, tenant expand, and delete
Generate command allows production users an opportunity to
optionally add/edit any additional fields in the yaml
before the tenant actually gets created.
Also rename operator create command to
operator init, volume add and volume list to
expand and info.