Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes loadbalancer port for healthcheck #301

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fixes loadbalancer port for healthcheck #301

merged 1 commit into from
Sep 21, 2020

Conversation

stefanhenseler
Copy link
Contributor

@stefanhenseler stefanhenseler commented Sep 21, 2020

It seems like the TLS Change a couple of commits ago broke the minio health check function and with that the status update of the Tenant CRD. This prevented the console from ever being deployed. I've changed the health function to use the LB ports depending on the TLS setting.

.vscode/launch.json Outdated Show resolved Hide resolved
okteto.yml Outdated Show resolved Hide resolved
pkg/resources/common/common.go Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

Port 9000 should be still accessible since that is still valid. Port 443/80 are just service ports only.

@stefanhenseler
Copy link
Contributor Author

Port 9000 should be still accessible since that is still valid. Port 443/80 are just service ports only.

That would work, but then we need to change the service name and use the headless one for this.

  • minio ClusterIP 10.63.245.183 80/TCP 19s
  • minio-hl ClusterIP None 9000/TCP 19s

@harshavardhana
Copy link
Member

That would work, but then we need to change the service name and use the headless one for this.

  • minio ClusterIP 10.63.245.183 80/TCP 19s
  • minio-hl ClusterIP None 9000/TCP 19s

Oh I see the bug is that service DNS doesn't now route to 9000

@harshavardhana harshavardhana merged commit f2c8dfc into minio:master Sep 21, 2020
@Alevsk
Copy link
Contributor

Alevsk commented Sep 21, 2020

Port 9000 should be still accessible since that is still valid. Port 443/80 are just service ports only.

That would work, but then we need to change the service name and use the headless one for this.

  • minio ClusterIP 10.63.245.183 80/TCP 19s
  • minio-hl ClusterIP None 9000/TCP 19s

using headless service for requests is not recommended because k8s will not load balance traffic
@harshavardhana port 9000 cannot be used anymore on the service since the only exposed ports are 443/80, targetPort its 9000

@dvaldivia
Copy link
Collaborator

I think we should only expose 9000 by default and let the users decide if they want a service with 80/443 since it would simplify operation, we could do this by either adding a service for internal k8s consumtion or making the service port configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants