Rename variable and regenerate CRD with controller-gen 0.4.0 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
Alevsk,
nitisht and
cesnietor
dvaldivia
changed the title
harshavardhana
previously approved these changes
Sep 22, 2020
dvaldivia
force-pushed
the
rename-variable
branch
from
9bf5664 to
150f411
Compare
harshavardhana
approved these changes
Sep 22, 2020
Alevsk
approved these changes
Sep 22, 2020
jmontleon
pushed a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
Fixes minio#300 Signed-off-by: David Zager <dzager@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames a variable called
namesince we import a package with the same namegithub.com/google/go-containerregistry/pkg/nameRe-generates the CRD for the project using
controller-gen 0.4.0which was the original version