Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CRD with Controller Gen v0.3.0 #308

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Sep 23, 2020

Reverting the CRD to controller-gen@v0.3.0 because the never CRD generated with v0.4.0 was failing on a k8s cluster.

The failure was that the annotations for the Tenant.Spec.Zone[].VolumeClaimTemplate the metadata of the volume template was not being stored at the k8s api server level, by reverting to a CRD generated with v0.3.0 the problem was fixed, we need to investigate further to determine what is v0.4.0 controller-gen doing wrong .

Some of the error that were thrown with the CRD that is being replaced:

ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.console.properties.resources.properties.limits.additionalProperties.schema has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.console.properties.resources.properties.requests.additionalProperties.schema has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.env.items.<array>.properties.valueFrom.properties.resourceFieldRef.properties.divisor has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.zones.items.<array>.properties.resources.properties.limits.additionalProperties.schema has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.zones.items.<array>.properties.resources.properties.requests.additionalProperties.schema has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.zones.items.<array>.properties.volumeClaimTemplate.properties.spec.properties.resources.properties.limits.additionalProperties.schema has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.zones.items.<array>.properties.volumeClaimTemplate.properties.spec.properties.resources.properties.requests.additionalProperties.schema has invalid property: anyOf
ERROR $root.definitions.io.min.minio.v1.Tenant.properties.spec.properties.zones.items.<array>.properties.volumeClaimTemplate.properties.status.properties.capacity.additionalProperties.schema has invalid property: anyOf

developer should downgrade to controller-gen@v0.3.0

GO111MODULE=on  go get -u sigs.k8s.io/controller-tools/cmd/controller-gen@v0.3.0

@harshavardhana harshavardhana merged commit e7b0db6 into minio:master Sep 23, 2020
jmontleon pushed a commit to jmontleon/operator that referenced this pull request Jul 23, 2024
Signed-off-by: David Zager <dzager@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants