Turn-off bucket DNS by default, make it opt-in #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable one must enable this explicitly. ``` s3: bucketDNS: true ``` It looks like many S3 API users seem to have buckets with `.` in them and would love to just use `path-style` instead of `bucket` DNS style. Making this an opt-in because users should be aware of the restrictions this would bring in for their bucket names.
kerneltime
approved these changes
Oct 5, 2020
dvaldivia
approved these changes
Oct 5, 2020
jmontleon
added a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable one must enable this explicitly.
It looks like many S3 API users seem to have buckets with
.in them and would love to just usepath-styleinsteadof
bucketDNS style.Making this an opt-in because users should be aware of the
restrictions this would bring in for their bucket names.