Re-queue Failed Items from the Work-queue #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You meant to say
|
dvaldivia
changed the title
|
@harshavardhana hahaha yes, let me try to amend the commit |
dvaldivia
force-pushed
the
requeue-failed-items
branch
from
c052668 to
ba73ba5
Compare
harshavardhana
previously approved these changes
Oct 9, 2020
…tween 5 seconds and 60 seconds max
Alevsk
approved these changes
Oct 9, 2020
harshavardhana
requested changes
Oct 9, 2020
| @@ -233,6 +238,7 @@ func NewController( | |||
| tenantInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ | |||
| AddFunc: controller.enqueueTenant, | |||
| UpdateFunc: func(old, new interface{}) { | |||
| // TODO: compare old vs new and don't enqueue if they are identical | |||
There was a problem hiding this comment.
Can you not use reflect.Equal(old, new) ?
There was a problem hiding this comment.
There's a package from kubernetes for that equality.Semantic.DeepEqual and equality.Semantic.DeepDerivative I experimented with both, they didn't work quite as I expected, I'll keep looking into it.
harshavardhana
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when we fail a work item (due to an error) we don't requeue the item, now that we are not needlessly triggering our tenant informer via status updates we need to requeue the work items whenever they fail.
Introduces
MinIOControllerRateLimiterwhich will make it so the re-queue exponential backoff times are always between 5s and 60s