Support for using AutoCert and External certificates #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
force-pushed
the
autocert-externalcerts
branch
from
0cf6bfc to
967ac4b
Compare
Alevsk
force-pushed
the
autocert-externalcerts
branch
from
967ac4b to
7d5f3ef
Compare
Alevsk
requested review from
dvaldivia,
nitisht,
harshavardhana,
aead and
kerneltime
harshavardhana
previously approved these changes
Oct 14, 2020
aead
previously approved these changes
Oct 14, 2020
nitisht
suggested changes
Oct 14, 2020
examples/tenant-with-autocert-and-custom-certs-encryption-enabled.yaml
Outdated
Show resolved
Hide resolved
- AutoCert is enabled by default, certificates will be generated for MinIO and Console and/or KES (if configuration is present) - User can choose to use automatic generated certificates and still provide his own certificates too, ie: if the tenant name is `minio` then minio-operator will generate certificates for `"minio.namespace.svc.cluster.local"`, `"minio-hl.namespace.svc.cluster.local"` and `"*.minio.namespace.svc.cluster.local"`, these certificates will be used for internal communication, in top of that user can provide extra certificates, eg: `"play.min.io"` and expose the minio cluster directly to the Internet under that subdomain. - Customer provided certificates will replace autogenerated certificates for `Console`, `KES` and `Minio Client Certificates` (the ones used for mTLS between MinIO and KES), in the case of MinIO the certificates will be added to a pool of certificates to serve via SNI.
Alevsk
force-pushed
the
autocert-externalcerts
branch
from
7d5f3ef to
7d716be
Compare
harshavardhana
approved these changes
Oct 14, 2020
aead
approved these changes
Oct 14, 2020
jmontleon
added a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miniothen minio-operator will generate certificates for"minio.namespace.svc.cluster.local","minio-hl.namespace.svc.cluster.local"and"*.minio.namespace.svc.cluster.local", these certificates will be used for internal communication, in top of that user can provide extra certificates, eg:"play.min.io"and expose the minio cluster directly to the Internet under that subdomain.Console,KESandMinio Client Certificates(the ones used for mTLS between MinIO and KES), in the case of MinIO the certificates will be added to a pool of certificates served via SNI.Test
To test this PR simply use the yaml file under
kubectl apply -f examples/tenant-with-autocert-and-custom-certs-encryption-enabled.yaml. This Yaml file will deploy a minio tenant with autocert enabled, certificates will be generated for minio for internal communications, for KES server and for the authentication between MinIO and KES (externalClientCertSecret), additionally external certificates are passed for MinIO (localhost domain) and Console (localhost domain)