Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update PV messaging #349

Merged
merged 1 commit into from
Nov 11, 2020
Merged

update PV messaging #349

merged 1 commit into from
Nov 11, 2020

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Nov 10, 2020

No description provided.

@abperiasamy
Copy link
Member

abperiasamy commented Nov 10, 2020 •
edited
Loading

Since MinIO has built-in erasure-code support for high-availability and data protection, we recommend the following CSI drivers for high-performance and scale:

@ravindk89
Copy link
Contributor

LGTM with AB's recommendations. maybe "scale" -> "scalability"

Also wondering if we should explicitly warn against using network-attached PV, such as NFS or a cloud provider-backed volume. Maybe something like "MinIO recommends against Persistent Volume drivers or plugins which use network-attached storage, as network latency reduces performance compared to locally-attached disks."

@harshavardhana
Copy link
Member

Also wondering if we should explicitly warn against using network-attached PV, such as NFS or a cloud provider-backed volume. Maybe something like "MinIO recommends against Persistent Volume drivers or plugins which use network-attached storage, as network latency reduces performance compared to locally-attached disks."

Yes, we should @ravindk89 especially NFS being used with MinIO distributed setup.

@nitisht
Copy link
Contributor Author

nitisht commented Nov 11, 2020

Addressed the comments, PTAL @kannappanr @ravindk89

@ravindk89
Copy link
Contributor

LGTM

@harshavardhana harshavardhana merged commit a7c8351 into minio:master Nov 11, 2020
@nitisht nitisht deleted the csi branch November 12, 2020 03:08
jmontleon pushed a commit to jmontleon/operator that referenced this pull request Jul 23, 2024
@djzager
Revert 0.5 (minio#349)
011a031 
Reverts:
- konveyor/operator#348
- konveyor/operator#347
- konveyor/operator#346

Signed-off-by: David Zager <dzager@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravindk89 ravindk89 ravindk89 approved these changes

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitisht @abperiasamy @ravindk89 @harshavardhana