Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup operator plugin #376

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Cleanup operator plugin #376

merged 2 commits into from
Dec 4, 2020

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Dec 2, 2020

Also update the statik files to refer to changes
done in #371

ravindk89
ravindk89 requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, but a few asks that I think will reduce friction for first-time users (+ some CYA on our end for destructive operations).

kubectl-minio/cmd/delete.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/helpers/constants.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/tenant-create.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/tenant-delete.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/tenant-delete.go Show resolved Hide resolved
kubectl-minio/cmd/tenant-create.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/tenant-create.go Show resolved Hide resolved
kubectl-minio/cmd/resources/tenant.go Outdated Show resolved Hide resolved
kubectl-minio/cmd/tenant-create.go Show resolved Hide resolved
kubectl-minio/cmd/tenant-upgrade.go Outdated Show resolved Hide resolved
ravindk89
ravindk89 previously approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on my end. We can always clean up messaging later, functionality is more important right now.

@ravindk89 ravindk89 mentioned this pull request Dec 3, 2020
Closed
@harshavardhana
Copy link
Member

Please rebase the changes to master @nitisht

harshavardhana
harshavardhana reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the changes LGTM

@nitisht
Cleanup operator plugin
03c3b8b 
Also update the statik files to refer to changes
done in #371
harshavardhana
harshavardhana previously approved these changes Dec 4, 2020
View reviewed changes
@harshavardhana harshavardhana requested a review from Alevsk December 4, 2020 21:54
@harshavardhana harshavardhana merged commit 9901d1d into minio:master Dec 4, 2020
@ravindk89 ravindk89 mentioned this pull request Dec 4, 2020
Merged
@nitisht nitisht deleted the plugin-fixes branch December 6, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravindk89 ravindk89 ravindk89 left review comments

@Alevsk Alevsk Alevsk approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@Praveenrajmani Praveenrajmani Awaiting requested review from Praveenrajmani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitisht @harshavardhana @Alevsk @ravindk89