Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audit webhook endpoint for log search api server #382

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Fix audit webhook endpoint for log search api server #382

merged 2 commits into from
Dec 4, 2020

Conversation

krisis
Copy link
Member

@krisis krisis commented Dec 4, 2020

No description provided.

@krisis krisis requested a review from donatello December 4, 2020 00:51
harshavardhana
harshavardhana previously approved these changes Dec 4, 2020
View reviewed changes
harshavardhana
harshavardhana previously approved these changes Dec 4, 2020
View reviewed changes
donatello
donatello previously approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can remove the empty config parameter too.

pkg/controller/cluster/log-search.go Outdated Show resolved Hide resolved
@krisis @donatello
Update pkg/controller/cluster/log-search.go
bd5e528 
Co-authored-by: Aditya Manthramurthy <donatello@users.noreply.github.com>
@krisis krisis dismissed stale reviews from donatello and harshavardhana via bd5e528 December 4, 2020 18:27
@harshavardhana harshavardhana merged commit e25e50e into minio:master Dec 4, 2020
@krisis krisis deleted the logsearch-fix branch December 4, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@donatello donatello donatello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisis @donatello @harshavardhana