Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus support in operator #399

Merged
merged 7 commits into from
Dec 22, 2020
Merged

Conversation

donatello
Copy link
Member

Creates a prometheus stateful set and configures it to pull metrics from all minio instances.

Prometheus is configured via an operator generated configuration map.

This PR works same as #390 but uses a config map instead.

- Include support for annotations, labels and nodeSelector for prometheus pods
- Include support for limit resources for prometheus
dvaldivia
dvaldivia previously approved these changes Dec 22, 2020
Alevsk
Alevsk previously approved these changes Dec 22, 2020
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatello donatello dismissed stale reviews from Alevsk and dvaldivia via b0cd083 December 22, 2020 23:45
@dvaldivia dvaldivia merged commit da4e5b9 into minio:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants