-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prometheus config map #407
Conversation
ea93893
to
5651641
Compare
91063c8
to
23cf89f
Compare
Is this still draft ? @donatello |
Is this still a draft ? @donatello - should this be part of the v2 change or no? |
It is. There is a problem with reacting to changes in configmaps. We need to signal prometheus to reload config after updating the config. So far it is not working properly because there is a propagation delay in config map change to mounted volume change and racing with reload of the prom server. I am trying to do something like a config map informer to fix this issue and hope to get it done mid next week. It is needed for prometheus to be reconfigured on minio password, tls or pool changes. |
28d2c1b
23cf89f
to
28d2c1b
Compare
- in case of secretkey, tls config or minio endpoints change. - Change UpdatePrometheusConfigMap MinIO secret key change detection: Use jwt validation of current prometheus config bearer token to detect if MinIO secret key has changed. - Use sidecar pattern to reload prometheus config on config file changes.
28d2c1b
to
7f5726a
Compare
@harshavardhana @dvaldivia This is working now. I took a sidecar pattern approach to reload prometheus config on config file changes. There doesn't seem to be a simple way to listen for configmap changes. |
in case of secretkey, tls config or minio endpoints change.
Change UpdatePrometheusConfigMap MinIO secret key change detection: Use jwt
validation of current prometheus config bearer token to detect if MinIO secret
key has changed.
Use sidecar pattern to reload prometheus config on config file changes.