Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus config map #407

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

donatello
Copy link
Member

@donatello donatello commented Dec 24, 2020

  • in case of secretkey, tls config or minio endpoints change.

  • Change UpdatePrometheusConfigMap MinIO secret key change detection: Use jwt
    validation of current prometheus config bearer token to detect if MinIO secret
    key has changed.

  • Use sidecar pattern to reload prometheus config on config file changes.

@donatello donatello force-pushed the update-prom-config branch 3 times, most recently from ea93893 to 5651641 Compare December 24, 2020 00:45
@krisis krisis force-pushed the update-prom-config branch 3 times, most recently from 91063c8 to 23cf89f Compare December 25, 2020 01:14
dvaldivia
dvaldivia previously approved these changes Jan 9, 2021
harshavardhana
harshavardhana previously approved these changes Jan 9, 2021
@harshavardhana
Copy link
Member

Is this still draft ? @donatello

@harshavardhana
Copy link
Member

Is this still draft ? @donatello

Is this still a draft ? @donatello - should this be part of the v2 change or no?

@donatello
Copy link
Member Author

Is this still a draft ? @donatello - should this be part of the v2 change or no?

It is. There is a problem with reacting to changes in configmaps. We need to signal prometheus to reload config after updating the config. So far it is not working properly because there is a propagation delay in config map change to mounted volume change and racing with reload of the prom server. I am trying to do something like a config map informer to fix this issue and hope to get it done mid next week. It is needed for prometheus to be reconfigured on minio password, tls or pool changes.

@donatello donatello dismissed stale reviews from harshavardhana, dvaldivia, and ghost via 28d2c1b February 3, 2021 23:15
- in case of secretkey, tls config or minio endpoints change.

- Change UpdatePrometheusConfigMap MinIO secret key change detection: Use jwt
validation of current prometheus config bearer token to detect if MinIO secret
key has changed.

- Use sidecar pattern to reload prometheus config on config file changes.
@donatello donatello marked this pull request as ready for review February 3, 2021 23:30
@donatello
Copy link
Member Author

@harshavardhana @dvaldivia This is working now. I took a sidecar pattern approach to reload prometheus config on config file changes. There doesn't seem to be a simple way to listen for configmap changes.

@nitisht nitisht merged commit 318498a into minio:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants