Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove namespace create/delete privileges from Operator #445

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Remove namespace create/delete privileges from Operator #445

merged 1 commit into from
Feb 2, 2021

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Feb 1, 2021 •
edited
Loading

Also do not automatically create namespaces in
Operator plugin

Fixes #441

@dvaldivia
Copy link
Collaborator

Still need to remove namespace from the cluster-role.yaml on line 32 (of the pr version)

@kannappanr kannappanr requested a review from Alevsk February 1, 2021 23:38
@nitisht
Remove namespace create/delete privileges from Operator
b768853 
Also do not automatically create namespaces in
Operator plugin.

Fixes #441
@nitisht
Copy link
Contributor Author

nitisht commented Feb 2, 2021

Still need to remove namespace from the cluster-role.yaml on line 32 (of the pr version)

Great catch, thank you. Removed.

@harshavardhana
Copy link
Member

PTAL @Praveenrajmani @Alevsk @kerneltime @dvaldivia

Praveenrajmani
Praveenrajmani approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 48ccec0 into minio:master Feb 2, 2021
@nitisht nitisht deleted the namespace-priv branch February 2, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@kerneltime kerneltime Awaiting requested review from kerneltime

@Alevsk Alevsk Awaiting requested review from Alevsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we reduce the required CustomResourceDefinitions permissions to run the MinIO operator?
4 participants
@nitisht @dvaldivia @harshavardhana @Praveenrajmani