Delete operator service on plugin delete and skip existing items on c… #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reation
Fixes #473
Operator service was not being deleted on
kubectl-minio delete
also change to not returning the errorwhen resource already exist on
init
command.Also on deletion, skip if item was not found since it is not there already.
Note:
This also brings the discussion if whether we should just logg instead of returning any other type of errors on deletion
as well as if we should have a defer function during creation to delete items created if something failed during
init
command.Test:
To test:
3.and run :
By then all resources including
Service
operator should be deleted.5. Create again:
Plugin should be generated with no errors
6. Create again2:
plugin should just return skipped items during creation: