Removing certificates.k8s.io/v1beta1 in favor of certificates.k8s.io/v1 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 22, 2021
ravindk89
reviewed
Feb 22, 2021
ravindk89
reviewed
Feb 23, 2021
- CertificateSigningRequest is deprecated in v1.19+ - Kubernetes minimum requirement for Operator is `v1.19`
ravindk89
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
No objections from a docs perspective.
One thought - this requires users to upgrade their K8s clusters to 1.19 even if they previously had a working tenant. Not sure if this needs a larger callout, but based on internal convos 1.18 is old enough where it seems like requiring a cluster upgrade is reasonable.
dvaldivia
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.19