Fix: helm chart creates only one Tenant when multiple defined(#598) #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
suggested changes
May 10, 2021
There was a problem hiding this comment.
Please apply these changes to your PR, we can then take this in
diff --git a/helm/minio-operator/templates/console-secret.yaml b/helm/minio-operator/templates/console-secret.yaml
index c07a432..2cf7c18 100644
--- a/helm/minio-operator/templates/console-secret.yaml
+++ b/helm/minio-operator/templates/console-secret.yaml
@@ -1,10 +1,10 @@
-{{ $namespace := .Release.Namespace }}
{{ range .Values.tenants }}
+---
apiVersion: v1
kind: Secret
metadata:
name: {{ .console.secrets.name }}
- namespace: {{ $namespace }}
+ namespace: {{ .namespace }}
type: Opaque
data:
## Passphrase to encrypt jwt payload
diff --git a/helm/minio-operator/templates/tenant-secret.yaml b/helm/minio-operator/templates/tenant-secret.yaml
index a36b068..67ac829 100644
--- a/helm/minio-operator/templates/tenant-secret.yaml
+++ b/helm/minio-operator/templates/tenant-secret.yaml
@@ -1,4 +1,5 @@
{{ range .Values.tenants }}
+---
apiVersion: v1
kind: Secret
metadata:
Signed-off-by: dnskr <dnskrv88@gmail.com>
nitisht
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue#598