feat: add an option to disable OperatorTLS based on env var #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Jul 13, 2021
harshavardhana
requested changes
Jul 14, 2021
This PR adds support to disable automatic certificate creation for Operator webhook server. This is required for some k8s distros where CSR support is not mature yet. Operator still uses TLS by default for its webhook server. This PR also adds a fix in kubectl plugin tenant upgrade command to ensure proper error message is sent to the user.
harshavardhana
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to disable automatic certificate
creation for Operator webhook server. This is required for
some k8s distros where CSR support is not mature yet.
Operator still uses TLS by default for its webhook server.
This PR also adds a fix in kubectl plugin tenant
upgrade command to ensure proper error message is sent
to the user.