-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenants will work only with embedded console #751
Conversation
Existing console fields are now deprecated and will be removed moving forward. Also upgrade to latest MinIO release.
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia minor question - for setting up SSO via Console, I think we'd expect to have to also set |
everything should be handle in this PR - AFAICS @ravindk89 |
I'll take your word for it, I didn't see the var being set at a glance, but I also don't know all the places to look. I did see we're setting |
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to test this branch in detail, deploying tenants with oidc, ldap, encryption options, etc, hows is gonna work with console/operator-ui? we will need a new version correct?, ill test all this tonight and tomorrow
@ravindk89 @harshavardhana we could have the OIDC callback be set by the browser sine we start the request from there, this would ensure we always can infer the domain regardless of the configuration |
If it's possible that would be great. |
It would certainly simplify a recent pain point if that were the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried updating the Operator image. Here are the steps:
- Create Operator
v4.1.3
and Tenant with Console enabled. - Upgrade Operator to image based on this PR.
Issues:
- Old console pods are not getting deleted/removed.
- Getting this warning in the Service.
Warning FailedToUpdateEndpointSlices 9m11s endpoint-slice-controller Error updating Endpoint Slices for Service default/minio-console: failed to update minio-console-l9vrs EndpointSlice for Service default/minio-console: Operation cannot be fulfilled on endpointslices.discovery.k8s.io "minio-console-l9vrs": the object has been modified; please apply your changes to the latest version and try again
@nitisht you need to perform a MinIO update to get rid of the console pods |
ah right. Let me try that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & basic migration scenarios working fine
This PR builds on top of @nitisht PR but has some extra changes, such as:
.spec.console
from the tenantkubectl minio tenant create
now creates a single user for the tenantTo Test this make sure to build a new logsearch container image and use that either as the default image or in the tenant's
.spec.log.image
field