Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Topology Spread Constraints feature. #859

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Support for Topology Spread Constraints feature. #859

merged 6 commits into from
Oct 15, 2021

Conversation

mshanmu
Copy link
Contributor

@mshanmu mshanmu commented Oct 6, 2021

This PR adds support for Topology Spread Constraints feature. The Topology Spread constraints specification allows the pods to be spread across your cluster among multiple failure-domains.

@nitisht

…y Spread constraints specification allows the pods to be spread across your cluster among multiple failure-domains.
@dvaldivia dvaldivia requested review from Alevsk, dvaldivia and kanagarajkm and removed request for Alevsk October 6, 2021 15:07
@dvaldivia
Copy link
Collaborator

This looks great, I'll test it and add some comments.

Since this is a 1.19 stable feature that requires a special flag before 1.18 per the documentation (included below) we must ensure this works on other versions, namely 1.17 and 1.18

Note: In versions of Kubernetes before v1.18, you must enable the EvenPodsSpread feature gate on the API server and the scheduler in order to use Pod topology spread constraints.

@mshanmu
Copy link
Contributor Author

mshanmu commented Oct 7, 2021

Thanks, @dvaldivia !! Please let me know if I need to do anything else.

Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with k8s 1.17 and 1.21. On 1.17 the topology gets removed from the statefulset but I didn't observe any re-sync of the statefulset from our operator, which might indicate either no problem, or no changes detected (which should happen)

@dvaldivia dvaldivia merged commit afbf880 into minio:master Oct 15, 2021
@mshanmu
Copy link
Contributor Author

mshanmu commented Oct 19, 2021

@dvaldivia , Can you link this PR with the #666 issue? I cannot seem to assign this issue to myself and close it.

@mshanmu mshanmu deleted the support-topology-spread-constraints branch October 20, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants