Permit passing ENV vars to console #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Young <davidy@funkypenguin.co.nz>
harshavardhana
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I've been working on getting SSO working for my operator console, and I realized that if I manually update the deployment to include
CONSOLE_IDP_URL,CONSOLE_IDP_CLIENT_ID, andCONSOLE_IDP_CALLBACK, then SSO works!It seems that it's not possible currently to pass these env vars to the console deployment though, so this PR simply adds in the optional capability to do so.
I've not bumped the chart version or the docs, since I'm not sure how these are intended to be updated, but I'm happy to do so with some direction :)
Cheers!
D