Add build automation for Helm Chart #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
changed the title
|
Ok guys the PR is ready for review, I added a test for Helm deployment of the operator. |
cniackz
changed the title
|
Wait for another improvement, I am testing that we can re-use the wait for helm and kustomize when installing the operator... wip |
cniackz
changed the title
|
Yes, it is ready for review @harshavardhana |
dvaldivia
approved these changes
Feb 1, 2022
harshavardhana
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea I have in mind is to add a test to deploy MinIO Operator using Helm as there is no test for this yet. I might change or update the test accordingly after Daniel's input on this task.
Fixes miniohq/engineering#402