Adding replicate_source_db variable to support read_replica #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogaal
approved these changes
Jun 18, 2020
| name = "rds-snapshots-user-${random_id.id.hex}" | ||
| path = "/system/rds-snapshots-user/" | ||
| } | ||
|
|
||
| resource "aws_iam_access_key" "user" { | ||
| user = aws_iam_user.user.name | ||
| count = var.replicate_source_db != "" ? 0 : 1 |
There was a problem hiding this comment.
Do it like count = var.replicate_source_db ? 1 : 0, it is more neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ministryofjustice/cloud-platform#1859
Variable db_identifier and skip_final_snapshot can now be changed when using this module
Creating read replica db instance doesnot require several variables to be passed when creating RDS instance such as aws_kms_key, db_subnet_group, DB username and DB password.
For read replica, final_snapshot_identifier has to be null as there are no snapshots created for read replica.
Variable skip_final_snapshot has to be set to true for read replica. For normal RDS instance, it is set to false(default)
ca_cert_identifier is not set explicitly as this causes read replica to reboot and not-ready state. Related to: hashicorp/terraform-provider-aws#11905
All the users of this module have set to default rds-ca-2019. So no users use old certificate.