Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPT-1932 London disclosure ICO SAR appeal decision updat. #2523

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

CDPT-1932 London disclosure ICO SAR appeal decision updat. #2523

wants to merge 13 commits into from

Conversation

njpreddy
Copy link
Contributor

Description

Self-review checklist

  • (1) Quick stakeholder demo done OR
  • (2) ...bug with before and after screenshots
  • (3) Tests passing
  • (4) Branch ready to be merged (not work in progress)
  • (5) No superfluous changes in diff
  • (6) No TODO's without new ticket numbers
  • (7) PR Prefixed with ticket number e.g. CT-7654 ...
  • (8) Data migration script is created if any of letter templates is changed

Screenshots

Related JIRA tickets

Deployment

Manual testing instructions

@njpreddy
Update button text
385dd34
@njpreddy
Remove errant comma
0821344
@njpreddy
WIP
7043c7b 
- Add radio button options to model.
- Add new complaint outcome page.
- Add page title to locale.
- Add button title to locale.
@njpreddy
WIP
cbaeb4e 
Updated outcome key names.
Added json accessor property.
@njpreddy
Update SAR case parameters
3bd028a
@njpreddy
WIP
3827355 
- Shortened sar_complaint_outcome(s) references to complaint_outcome(s).
- Deleted shared option file.
- Tepmporarily hard code radio button options.
@njpreddy
WIP
2e3bee8 
- Add outcome recording method to controller.
- Amend SAR case params
- Amend model outcome constant and accessor.
- Amend outcome radio button rendering.
@njpreddy
wip
efa59d4
@njpreddy
Updated complaint outcome page.
654a23d
@njpreddy
Update routes
dc01604
@njpreddy
WIP
e8f3510 
- Updated workflow branch logic for timely ICO SARs.
- Remove empty line to fix rubocop offence
@njpreddy
WIP
b719739
@njpreddy
Un-comment form options.
17d23a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@njpreddy