El 1975 hook up translation link #429
Conversation
kmahern
force-pushed
the
el-1975-hook-up-translation-link
branch
8 times, most recently
from
c3ec7de to
6ff2840
Compare
kmahern
changed the base branch from
el-1975-hook-up-translation-button
to
main
kmahern
force-pushed
the
el-1975-hook-up-translation-link
branch
2 times, most recently
from
146bc3b to
2f59850
Compare
kmahern
force-pushed
the
el-1975-hook-up-translation-link
branch
from
e210460 to
711624e
Compare
kmahern
force-pushed
the
el-1975-hook-up-translation-link
branch
from
a86092e to
b94213c
Compare
and remove inline javascript
fala/common/mixin_for_views.py
Outdated
| def translation_link(self, request): | ||
| user_language = request.COOKIES.get("django_language", "en") | ||
| if user_language == "cy": | ||
| return "<a class='govuk-body govuk-link' id='language_switcher_link'>English</a> / Cymraeg" |
There was a problem hiding this comment.
I've spotted a small problem. These anchor links do not have href. Because of that the link doesn't show a cursor icon when you hover over them.
An tag without an href attribute fails accessibility because it is not recognised as an interactive element by screen readers, keyboard navigation, and assistive technologies.
You will need to add href="#" However the anchor link may try and go to the URL, so below in the JS I have added some code to help prevent that.
There was a problem hiding this comment.
You're also missing some other needed attributes
These are all on DWP component so you can find anything you've missed and need there.
hreflang="cy"
lang="cy"
rel="alternate"
aria-label="Newid yr iaith ir Gymraeg"
There was a problem hiding this comment.
👍 thanks @psweeting1 have made these updates. I think the form seems to work without the javascript to prevent the link behaviour but this is definitely worth testing.
fala/common/mixin_for_views.py
Outdated
| if user_language == "cy": | ||
| return "<a class='govuk-body govuk-link' id='language_switcher_link' href='#' hreflang='en' lang='en' rel='altternate' aria-label='English'>English</a> / Cymraeg" | ||
| else: | ||
| return "English / <a class='govuk-body govuk-link' id='language_switcher_link' href='#' hreflang='cy' lang='cy' rel='altternate' aria-label='Cymraeg'>Cymraeg</a>" |
There was a problem hiding this comment.
Can you use DWP's Aria label as they've got a really good descriptions for both welsh and english. aria-label should always be descriptive and meaningful, providing enough context for screen readers to understand the purpose of the element.
Both english and welsh aria labels say "change language to X" on the DWP ones.
|
What does this pull request do?
Any other changes that would benefit highlighting?
Intentionally left blank.
Checklist