refactor: rename timestamps #1110
Conversation
There are various datetimes returned by Datahub, and it's easy to confuse them. It seems like we are not always using the right one, so as a first step I'm renaming all the parse functions to clearly describe what they are actually returning.
There was a problem hiding this comment.
Do you think we could go a bit further and rename the properties in the pydantic entity model. Every entity should(or could) have a data_last_modified and a metadata_last_updated property so we could put these in the base entity class and remove reference to them elsewhere in entities.py? Plus they'd be clearer when used in the find-moj-data code
lib/datahub-client/data_platform_catalogue/client/datahub_client.py
Outdated
Show resolved
Hide resolved
Yeah that makes sense... I'll have a look at this now |
We have several timestamps that are easily confused. To try and make the code clearer, I'm defining them for all entities with explicit names that correspond to how they are stored in Datahub.
MatMoore
force-pushed
the
rename-timestamps
branch
from
abeac3b to
35983dd
Compare
MatMoore
changed the title
There are various datetimes returned by Datahub, and it's easy to confuse them. It seems like we are not always using the right one, so as a first step I'm renaming all the fields and parse functions to clearly describe what they are actually returning.
I've also exposed Datahub's lastModified value as I think this is the one we should be using for data last updated.
This does not change what is displayed yet, I'll do that in a follow up PR.