new-feature/signed-commits #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e graphql api. See Modernisation Platform story ministryofjustice/modernisation-platform#7689 for further information.
4 tasks
connormaglynn
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends the workflow to generate signed commits via the use of the graphql api and the createCommitOnBranch mutation. Because the api generates the commit on the remote branch, there is no requirement to push the commit from the origin and so that section was removed.
This action log shows the changes being successfully tested https://github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux/actions/runs/11140975903/job/30960904189
See Modernisation Platform story ministryofjustice/modernisation-platform#7689 for further information & context.