Adjust1 405 template updates #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependencies Also move to use declaration overrides for describing additional possible fields in session data Also removing/moving unnecessary prod dependencies Moving jest tests to run in parallel * Fix types for user * Do not allow any warnings * Correcting test results path
Also * Update dependencies * Adopt standard github gitignore for node projects * Using body typography
* Add rename script * PR reviews * Removing unused vars
* Decoupling auth client from redis impl
* Convert to arrow functions in utils * Remove returns and fix prettier issues
* Adding outdated job * Updating dependencies * Removing patch to minor version
* Add new veracode scan for schedueled workflow * Re-add - check_outdated job
…ks (#27) * Updating dependencies and adding slack notifications to outdated checks * Add slack orb
…n established in prison staff hub (#28)
* Ensure that the `SLACK_ACCESS_TOKEN` env var is set for `check_outdated` As the final step (on fail) is a slack notification we need to use a context containing the variable. * Refactor the channel for alerts into parameters This establishes a reusable pattern in case consumers wish to notify slack on other jobs.
The "medium" configuration was not an acceptable term, should be one of "info", "low", "moderate", "high" or "critical". This meant that it would not pick up on anything!
* Updating dependencies and node * Use parameterised slack channel rather than default of typescript alerts channel * Extracting out executor
* Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: nishanthmahasamudram <129746957+nishanthmahasamudram@users.noreply.github.com> Co-authored-by: Paul Solecki <51918433+psoleckimoj@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Upgrade to GovUK 5 and MoJ 2.0 * Update sass command
* Update all non major NPM dependencies * Update Node.js to v20.11.0 * Update dependency husky to v9
* Update MoJ frontend, dropping jQuery which is no longer required * Remove unused static assets route: `govuk_frontend_toolkit` is not currently included * Prevent renovate from updating `engines.node` and `engines.npm` in package.json because we’d usually want to stick to an LTS version rather than move to the latest
`node_modules/govuk-frontend/dist/components/` was missing `govuk/`
before `components/`, however we don't really need both the higher-level
and lower-level paths here. For greater consistency, just using the
higher-level path to enable a single clearly-namespaced route to each
GOV.UK and MOJ Nunjucks component makes more sense. The lower-level path
is often unused on projects that use this template
Imports should therefore look like this:
```njk
{% from "govuk/components/checkboxes/macro.njk" import govukCheckboxes %}
```
... and not this:
```njk
{% from "checkboxes/macro.njk" import govukCheckboxes %}
```
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ldlharper
force-pushed
the
ADJUST1-405-template-updates
branch
from
34e4e11 to
cf13d9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.