-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADJUST1-436 Back button in Edit tagged bail #177
Conversation
Ah so I didn't realise the code in the template was looking for an adjustment type. So I think the fix should change this part in the front end.
The adjustment type with the edit nunjucks file is always tagged bail. So this is just unnecessary extra complication. The adjustment type being added to the model was all done as part of the generic adjustment type form work. So you could use the same template for many different adjustment types. We know this template is only used for the tagged bail adjustment type. So the backlink is not dynamic. |
Removed usage of adjustmentType in tagged bail // Adjusted destination of cancel buttons // Updated page titles
@@ -66,7 +66,7 @@ | |||
{{ govukButton({ | |||
text: "Cancel", | |||
classes: "govuk-button--secondary", | |||
href: "/" + prisoner.prisonerNumber | |||
href: "/" + prisoner.prisonerNumber + "/tagged-bail/view" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this link will probably be conditional on whether or not your editing. The template and route are used for both create and edit. There is an addOrEdit
variable used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.