Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADJUST1-495 DR: UAL banner #219

Merged
merged 3 commits into from
Mar 12, 2024
Merged

ADJUST1-495 DR: UAL banner #219

merged 3 commits into from
Mar 12, 2024

Conversation

pavilionsahota
Copy link
Contributor

No description provided.

@pavilionsahota pavilionsahota requested a review from a team as a code owner March 11, 2024 12:09
@ldlharper
Copy link
Contributor

So I'd suggest a bit of a refactor here. If the messages are now going to be consistent for adjustment types. I'd remove all the different message types like REMAND_UPDATED TAGGED_BAIL_UPDATED and just have UPDATED. Pass the adjustment type in as a parameter.

You can also you the code within adjustmentTypes.ts to get the appropriate readable text for each adjustment type

ldlharper
ldlharper approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@ldlharper ldlharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldlharper ldlharper merged commit c294cc3 into main Mar 12, 2024
4 checks passed
@ldlharper ldlharper deleted the ADJUST1-495-DR-UAL-banner branch March 12, 2024 15:39
ldlharper added a commit that referenced this pull request Mar 12, 2024
@ldlharper
Revert "ADJUST1-495 DR: UAL banner (#219)"
75f1931 
This reverts commit c294cc3.
ldlharper added a commit that referenced this pull request Mar 12, 2024
@ldlharper
Revert "ADJUST1-495 DR: UAL banner (#219)" (#224)
29ac952 
This reverts commit c294cc3.
ldlharper added a commit that referenced this pull request Mar 12, 2024
@ldlharper
Revert "Revert "ADJUST1-495 DR: UAL banner (#219)" (#224)"
986dc64 
This reverts commit 29ac952.
pavilionsahota pushed a commit that referenced this pull request Mar 12, 2024
@ldlharper
ADJUST1-495 DR: UAL banner (#225)
601d7c3 
* Revert "Revert "ADJUST1-495 DR: UAL banner (#219)" (#224)"

This reverts commit 29ac952.

* Refactored logic to simplify request params

---------

Co-authored-by: Pavilion Sahota <pavilion.sahota@justice.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldlharper ldlharper ldlharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavilionsahota @ldlharper