CMG-91 upgrade to the new version of the hmpps-court-cases-release-dates-design package - to bring in mini-profile changes + change how status is populated #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes-design package - to bring in mini-profile changes + change how status is populated
ldlharper
reviewed
Mar 12, 2024
| lastName: prisoner.lastName, | ||
| prisonerNumber: prisoner.prisonerNumber, | ||
| dateOfBirth: prisoner.dateOfBirth, | ||
| status: prisoner.imprisonmentStatusDescription, |
There was a problem hiding this comment.
Is this change just specific to adjustments? Why wouldn't the change be done within the mini profile?
There was a problem hiding this comment.
the mini-profile is designed to be generic and agnostic of the source, so it has a field called 'status' which was previously populated by 'status' from the prisonerDetails now that field is populated by imprisonmentStatusDescription as far as adjustments and other legacy services are concerned
So, it's been designed in a way that any service can use it and decide what they want to put in the 'status' field
There was a problem hiding this comment.
Ah okay. I thought it was designed such that the prisoner passed in was always a prisoner object from search API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.