P4-2449 Support multiple assessments #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrw
commented
Nov 25, 2020
cwrw
changed the title
cwrw
commented
Nov 25, 2020
cwrw
commented
Nov 25, 2020
cwrw
force-pushed
the
P4-2449-support-multiple-frameworks
branch
from
5753b07
to
db6d897
Compare
cwrw
force-pushed
the
P4-2449-support-multiple-frameworks
branch
from
db6d897
to
79ca230
Compare
willfish
approved these changes
Nov 26, 2020
smoothcontract
approved these changes
Nov 26, 2020
jira-ticket: https://dsdmoj.atlassian.net/browse/P4-2449 To allow support for multiple assessments, move shared logic to an abstract controller for "assessmentables". Define the specific class in the specific controller for the assessment. Also move param validator to assessmentable service.
jira-ticket: https://dsdmoj.atlassian.net/browse/P4-2449 Rename contants to generic assessment for person escort record status enums.
jira-ticket: https://dsdmoj.atlassian.net/browse/P4-2449 * For reuse across multiple assessments, move PER model logic to a concern, and move tests to a shared example. * Rename state machine to a generic framework assessment name * Ignore rubocop warning as its a false positive
jira-ticket: https://dsdmoj.atlassian.net/browse/P4-2449 Move prefill belongs_to to per model, also cleanup unnecessary memoization.
cwrw
force-pushed
the
P4-2449-support-multiple-frameworks
branch
from
79ca230
to
65c44ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
P4-2449
What?
I have added/removed/altered:
Why?
To add support for the Youth risk assessment, which will initially reuse all logic from the Person Escort Record, extract shared logic into abstract parent classes and concerns.
Serializer reuse will be done in a separate pr.