CDPS-716 add no cell prisoners page #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitfield-mj
commented
May 24, 2024
| } | ||
|
|
||
| return null | ||
| } |
There was a problem hiding this comment.
Taken directly from DPS. I assume the cells always come back with establishment prefixes.... seem to in dev
whitfield-mj
force-pushed
the
CDPS-716-no-cell
branch
2 times, most recently
from
179cc51 to
ec4efbd
Compare
davidatmoj
reviewed
May 24, 2024
server/services/movementsService.ts
Outdated
| const { content: cellSwapPrisoners } = await prisonerSearchClient.getCswapPrisonersInEstablishment(caseLoadId) | ||
| if (!cellSwapPrisoners?.length) return [] | ||
|
|
||
| const prisonerNumbers = cellSwapPrisoners.map(prisoner => prisoner.prisonerNumber) |
There was a problem hiding this comment.
Seems like this is redundant as you could just use
cellSwapPrisoners.map(async prisoner =>
and delete the const prisoner = ...
in the following Promise.all
| {% else %} | ||
| <div class="govuk-grid-row"> | ||
| <div class="govuk-grid-column-two-thirds"> | ||
| <h1 class="govuk-heading-l">{{ title }}</h1> |
whitfield-mj
force-pushed
the
CDPS-716-no-cell
branch
from
ec4efbd to
d3ae115
Compare
davidatmoj
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.