SDI-88: 🚨 Second attempt to querystring warning

ministryofjustice · May 12, 2022 · 6d0cb5d · 6d0cb5d
1 parent cd048c4
commit 6d0cb5d
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/server/data/hmppsAuthClient.ts b/server/data/hmppsAuthClient.ts
@@ -16,17 +16,18 @@ function getSystemClientTokenFromHmppsAuth(username?: string): Promise<superagen
     config.apis.hmppsAuth.systemClientSecret
   )
 
-  const grantRequest = { grant_type: 'client_credentials', ...(username && { username }) }
+  const grantRequest = new URLSearchParams({
+    grant_type: 'client_credentials',
+    ...(username && { username }),
+  }).toString()
 
-  logger.info(
-    `HMPPS Auth request '${grantRequest}' for client id '${config.apis.hmppsAuth.systemClientId}' and user '${username}'`
-  )
+  logger.info(`${grantRequest} HMPPS Auth request for client id '${config.apis.hmppsAuth.systemClientId}''`)
 
   return superagent
     .post(`${hmppsAuthUrl}/oauth/token`)
     .set('Authorization', clientToken)
     .set('content-type', 'application/x-www-form-urlencoded')
-    .send(new URLSearchParams(grantRequest).toString())
+    .send(grantRequest)
     .timeout(timeoutSpec)
 }