Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIMAPP-1508] Summary card content updates #1291

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

EdwinKruglov
Copy link
Contributor

@EdwinKruglov EdwinKruglov commented Dec 18, 2024

Description of change

This addresses additional summary card content changes.

Link to relevant ticket

CRIMAPP-1508
Figma design

@EdwinKruglov EdwinKruglov marked this pull request as ready for review December 19, 2024 09:12
@EdwinKruglov EdwinKruglov requested a review from a team as a code owner December 19, 2024 09:12
Copy link
Contributor

@hiboabd hiboabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question

@@ -14,6 +14,10 @@ def change_path
def person
@person ||= crime_application.partner
end

def subject_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file require the HasDynamicSubject concern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It inherits it from Sections::PassportingBenefitCheck.

@EdwinKruglov EdwinKruglov merged commit 1381608 into main Dec 19, 2024
7 checks passed
@EdwinKruglov EdwinKruglov deleted the crimapp-1508-summary-card-feedback branch December 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants