Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simplified decisions data model #1295

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

timpeat
Copy link
Member

@timpeat timpeat commented Dec 23, 2024

Description of change

Use simplified Decisions data model.

Link to relevant ticket

Notes for reviewer

Screenshots of changes (if applicable)

Before changes:

After changes:

How to manually test the feature

@@ -6,15 +6,15 @@ en:
payment_answer_format: &payment_answer_format "%{amount} every %{frequency} %{tax_status}"
amount_and_frequency_answer: "%{amount} every %{frequency}"
YESNO: &YESNO
'yes': 'Yes'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again, my linter is working 😢

@@ -706,8 +706,8 @@ en:
funding_decision_ioj_result:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👇 start of changes

failmeioj:
value: Failed means and IoJ
refused:
value: Refused
colour: red
funding_decision_further_info:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ end of changes

@timpeat timpeat marked this pull request as ready for review December 23, 2024 15:50
@timpeat timpeat requested a review from a team as a code owner December 23, 2024 15:50
@timpeat timpeat force-pushed the CRIMAPP-907-use-latest-decision-schema branch from fb69935 to f864b9b Compare December 23, 2024 16:00
@timpeat timpeat merged commit 847ce9f into main Dec 23, 2024
7 checks passed
@timpeat timpeat deleted the CRIMAPP-907-use-latest-decision-schema branch December 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants