[CRIMAPP-1553] replace MoJ task list with Govuk one #1299
Conversation
timpeat
force-pushed
the
CRIMAPP-1553-task-list-accessibility
branch
from
5be2c21 to
7702a40
Compare
timpeat
changed the title
timpeat
force-pushed
the
CRIMAPP-1553-task-list-accessibility
branch
from
7702a40 to
e8ed131
Compare
|
|
||
| def all_tasks | ||
| @all_tasks ||= map(&:items).flatten | ||
| all_tasks.reject { |task| task.status.not_applicable? } | ||
| end | ||
|
|
There was a problem hiding this comment.
I've refactored the section renderer into two distinct parts: a TaskLit::Section (retaining the same class name as the old renderer) and a new TaskList::SectionComponent.
This change was driven by the lack of dedicated models for the TaskList classes. These classes currently encapsulate significant business logic, and could be used elsewhere. I believe moving towards dedicated models for Section, Task etc will improve things.
I've not moved them from the presenter folder, but I think we could. For now I've just separated business logic from view-related concerns.
| TaskStatus::IN_PROGRESS => 'light-blue', | ||
| TaskStatus::NOT_STARTED => 'blue', | ||
| TaskStatus::UNREACHABLE => nil, | ||
| TaskStatus::NOT_APPLICABLE => nil | ||
| }.freeze | ||
|
|
There was a problem hiding this comment.
See for https://design-system.service.gov.uk/patterns/complete-multiple-tasks/ for reasoning for changing the colours here:
Once the user has completed the task, the status should show as ‘Completed’ and be black text with no background colour. This will draw more attention to tasks that require action.
timpeat
force-pushed
the
CRIMAPP-1553-task-list-accessibility
branch
from
e8ed131 to
5788b6a
Compare
| tag.strong id: tag_id, class: tag_classes do | ||
| t!("tasklist.status.#{status}") | ||
| end | ||
| def to_hash |
There was a problem hiding this comment.
Instead of a render, this constructs arguments that can be used by
https://github.com/x-govuk/govuk-components/blob/main/app/components/govuk_component/task_list_component/status_component.rb
| @@ -10,6 +10,10 @@ def initialize(crime_application:) | |||
| @crime_application = crime_application | |||
| end | |||
|
|
|||
| def name | |||
There was a problem hiding this comment.
Moved name here so that we can use the task subclass rather than a sparate task presenter.
timpeat
force-pushed
the
CRIMAPP-1553-task-list-accessibility
branch
from
5788b6a to
f6b026c
Compare
Description of change
Move to latest GDS task list to address accessibility issues and improve identification of unfinished tasks.
Link to relevant ticket
CRIMAPP-1553
Notes for reviewer
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature