Chore: Address transaction type todo

[colinbruce]

What

While removing the citizen values and update tests to stop referring to them, I discovered that the only place referring to the citizen values were the user_transaction_helper specs.

When I investigated the helper, I could find no references to it's methods in the codebase.

Therefore I have removed the user_transaction_helper entirely and removed the citizen section of the locale file. The citizen path was phased out many years ago and they were left in place because of the now unused helper.

Checklist

Before you ask people to review this PR:

• Tests and rubocop should be passing: bundle exec rake
• Github should not be reporting conflicts; you should have recently run git rebase main.
• The standards in the Git Workflow document on Confluence should be followed
• There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
• The PR description should say what you changed and why, with a link to the JIRA story.
• You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
• You should have checked that the commit messages say why the change was made.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jsugarman]

🔥 LGTM