CRM457-2076: Go back to telling app store about new versions immediately

app/models/event.rb

@@ -22,9 +22,17 @@ class Event < ApplicationRecord
     'Event::DeleteAdjustments',
   ].freeze
 
+  # These are events that we know can exist in our local database for a significant
+  # period without existing in the app store database. All other events are either
+  # synced to the app store immediately after creation via a `.notify` call, or
+  # only created as part of a larger action that is followed immediately by a
+  # call to `NotifyAppStore` which syncs all events anyway.
+  # It is important to keep track of these so that we can infer what the app
+  # store thinks the latest event date is (so that the 'last updated' date
+  # we display in the UI is consistent with the value the app store uses
+  # for sorting and filtering search results)
   LOCAL_EVENTS = [
     'Event::DraftDecision',
-    'Event::NewVersion',
     'Event::Edit',
     'Event::Note',
     'Event::UndoEdit',

app/models/event/new_version.rb

@@ -1,7 +1,9 @@
 class Event
   class NewVersion < Event
     def self.build(submission:)
-      create(submission: submission, submission_version: submission.current_version)
+      # We notify the app store immediately of a new version, because its analytics mechanism
+      # depends on having new version events available.
+      create(submission: submission, submission_version: submission.current_version).tap(&:notify)
     end
 
     def body

db/migrate/20241018110747_back_fill_new_version_notifications.rb

@@ -0,0 +1,12 @@
+class BackFillNewVersionNotifications < ActiveRecord::Migration[7.1]
+  def change
+    # Unassessed submissions haven't been pushing their new version events to the app
+    # store recently. Once they are assessed or sent back those events get synced,
+    # so it's only the ones that are still awaiting assessment that could be out
+    # of sync
+    Submission.where(state: %w[submitted provider_updated]).find_each do |submission|
+      last_new_version_event = submission.events.where(event_type: 'Event::NewVersion').order(:created_at).last
+      last_new_version_event&.notify
+    end
+  end
+end