CCMSPUI-411: Upgrade GOVUK Frontend to 5.7.1 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…y/ccmspui-411-govuk-5.7.1 # Conflicts: # src/main/resources/scss/ccms.scss
… service navigation component. Fixed references to fragment to be <th:block/> elements to coincide with this change. Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
…nto story/ccmspui-411-govuk-5.7.1
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
|
I've just mereged my changes which has a new caab.js file. Are you able to merge the contents of that file into the all.js? |
@PhilDigitalJustice Not currently. Would need to implement However you did highlight that gulpfile.js is copying |
… the correct location Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading GOVUK Frontend from
5.3.1to5.7.1.Changes
5.5.0: GOVUK Frontend includes updated colour paleteNot much change to frontend for this inclusion, rather using the colour palette directly in
.scsswhere a colour is used.5.6.0: Updated header to use the services component5.7.0: Crest updated to use King Charles III logoThis change was partially done when CCMSPUI-408 was merged, however part of this PR it's been checked properly.
Before:
After:
Changes to GDS but not to project
Listing changes to GDS which did not effect the project but were worth noting as part of my findings.
5.4.1: Breadcrumbs to usenavinstead ofdivand to add an aria-label which was introduced in.5.5.0: There is a class now added which helps wrap longer words which would usually trail off screen. You can do this by wrapping the content with the classgovuk-!-text-break-word.