Fix Celery 4 upgrade with SQS #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change pins Kombu to an unreleased commit that fixes Celery 4 to work properly with SQS. While testing on the dev environment it became clear that while the celery worker was able to connect to the SQS queue it wasn't actually receiving any messages off it. The issue linked below [1] shows that Celery 4.0.2 does not work correctly with SQS. While there is a fix that that has been merged on Kombu [2] this has not made it into a release yet which is why this change pins Kombu to a commit on master. I have tested the Kombu commit with a minimal Django 1.11 app using SQS as the broker. [1] celery/celery#3672 [2] celery/kombu#693
|
Can one of the admins verify this patch? |
robyoung
added a commit
that referenced
this pull request
Jun 28, 2017
This should have been added with #354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pins Kombu to an unreleased commit that fixes Celery 4 to work properly with SQS.
While testing on the dev environment it became clear that while the celery worker was able to connect to the SQS queue it wasn't actually receiving any messages off it. There is an issue on Celery 4.0.2 that shows it does not work correctly with SQS. While there is a fix that that has been merged on Kombu this has not made it into a release yet which is why this change pins Kombu to a commit on master.
I have tested the Kombu commit with a minimal Django 1.11 app using SQS as the broker.