Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default_tags in AWS Provider statements #5637

Merged
merged 1 commit into from
May 1, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Apr 9, 2024

As a possible example for ministryofjustice/modernisation-platform#1519, this PR implements the use of default_tags as configured in version 5.0 and above of the Terraform AWS Provider, using the common values in local.tags:

provider "aws" {
  default_tags { tags = local.tags }
}

@dms1981 dms1981 requested a review from a team as a code owner April 9, 2024 13:33
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Apr 9, 2024
@dms1981 dms1981 had a problem deploying to example-development April 9, 2024 13:34 — with GitHub Actions Failure
Copy link
Contributor

github-actions bot commented Apr 9, 2024

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

Copy link
Contributor

@SteveLinden SteveLinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have tried this before but if it works we'll save some time/effort in future

@dms1981 dms1981 merged commit c4b30e9 into main May 1, 2024
9 of 10 checks passed
@dms1981 dms1981 deleted the feature/example-default-tags branch May 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants