Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to incident management documentation - added summary #8740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimonPPledger
Copy link
Contributor

A reference to the issue / Description of it

Added summary and some clarifications to incident management runbook

How does this PR fix the problem?

Makes the documentation less confusing

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

have run and viewed locally

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

n/a

Checklist (check x in [ ] of list items)

  • [x ] I have performed a self-review of my own code
  • [ x] All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@SimonPPledger SimonPPledger requested a review from a team as a code owner December 12, 2024 09:46
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 12, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me, although the key steps do not always match the heading names, but it makes sense to me (and the key steps are probably more meaningful than the current headings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants