SAA-2291: Introduce convention for strings with number prefix

[natclamp-moj]

Identify the bug

#1107

Description of the change

Instead of running all cell values through parseFloat, which converts strings with number prefixes to just the number, we use Number to evaluate the entire value to see whether it's a number or not. If the value is NaN, the function returns the original value (this includes strings with number prefixes) for use in the sort. If the value is a number, we can then safely use parseFloat on the sort value, as we know it won't be removing any non-numerical components of the value.

Alternative designs

Number evaluates the entire value, whereas parseFloat stops when you get to a non-numerical part.
You could use parseFloat and then check the result against the original input value, and use the original value if it is different from the result of the parseFloat, but this is more long-winded and potentially error-prone.

Possible drawbacks

Number converts empty strings and null to 0. I think that this works fine when sorting - if I had a cell which looked empty, I'd rather it was at the bottom of the table rather than at the top - but this depends on your point of view.

Verification process

Verified against existing tests and introduced a new test with a variety of input values.

Release notes

• Provides a better convention for sorting if strings contain a number prefix

[gregtyler]

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀