Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDLS-415 fix role syntax in terraform due to deprecation #1754

Merged
merged 2 commits into from
Dec 4, 2024
Merged

DDLS-415 fix role syntax in terraform due to deprecation #1754

merged 2 commits into from
Dec 4, 2024

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Dec 3, 2024 •
edited
Loading

Purpose

Upgrade TF and fix deprecation

Fixes DDLS-415

Approach

NA

Learning

NA

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@jamesrwarren jamesrwarren marked this pull request as ready for review December 4, 2024 13:52
@jamesrwarren jamesrwarren requested a review from a team as a code owner December 4, 2024 13:52
@jamesrwarren jamesrwarren merged commit c17b6ec into main Dec 4, 2024
37 checks passed
@jamesrwarren jamesrwarren deleted the DDLS-415 branch December 4, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqpalm iqpalm iqpalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesrwarren @iqpalm