Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-410 Professional report pdf is missing the significant decisions for case #1761

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iqpalm
Copy link
Contributor

@iqpalm iqpalm commented Dec 9, 2024

Purpose

The pdf for the report has been submitted by the professional deputy but part of the report is missing. The deputy has selected ‘yes' for the question Have you made any significant decisions for in this reporting period? However, the significant decisions have been cut off. The question is right at the bottom of the page and then begins on the next page with a new question.

Fixes DDLS-410

Approach

The problem seems to be when the significant decisions are longer than one page. I included an extra div tag separating the yes/no question and the significant decisions.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@iqpalm iqpalm changed the title DDLS-410 Professional report pdf is missing the significant decisions for case 13629868 DDLS-410 Professional report pdf is missing the significant decisions for case Dec 9, 2024
@iqpalm iqpalm marked this pull request as ready for review December 10, 2024 09:11
@iqpalm iqpalm requested a review from a team as a code owner December 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants