Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-416: NDR missing sections of the pdf #1768

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DDLS-416: NDR missing sections of the pdf #1768

wants to merge 3 commits into from

Conversation

MiaGordon91
Copy link
Contributor

@MiaGordon91 MiaGordon91 commented Dec 13, 2024

Purpose

It appears that the full section of the client assets data of a NDR report pdf is cut off when a deputy adds a property as an asset. All other asset options from this section render fine on the pdf, even if you add multiple assets.

This also impacts PFA reports if a deputy selects a property alongside other assets.

Fixes DDLS-416

Approach

  • Wrapped the entire property html within a div tag to ensure all markup is rendered on a page and not cut off - this has been applied to the NDR and standard report property twig file

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@MiaGordon91 MiaGordon91 marked this pull request as ready for review December 13, 2024 12:24
@MiaGordon91 MiaGordon91 requested a review from a team as a code owner December 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant